12 comments

  • apapalns 11 hours ago
    > codebase with hundreds of thousands of lines of code and go from 0% to 80%+ coverage in the next few weeks

    I had a coworker do this with windsurf + manual driving awhile back and it was an absolute mess. Awful tests that were unmaintainable and next to useless (too much mocking, testing that the code “works the way it was written”, etc.). Writing a useful test suite is one of the most important parts of a codebase and requires careful deliberate thought. Without deep understanding of business logic (which takes time and is often lost after the initial devs move on) you’re not gonna get great tests.

    To be fair to AI, we hired a “consultant” that also got us this same level of testing so it’s not like there is a high bar out there. It’s just not the kind of problem you can solve in 2 weeks.

    • simonw 10 hours ago
      I find coding agents can produce very high quality tests if and only if you give them detailed guidance and good starting examples.

      Ask a coding agent to build tests for a project that has none and you're likely to get all sorts of messy mocks and tests that exercise internals when really you want them to exercise the top level public API of the project.

      Give them just a few starting examples that demonstrate how to create a good testable environment without mocking and test the higher level APIs and they are much less likely to make a catastrophic mess.

      You're still going to have to keep an eye on what they're doing and carefully review their work though!

      • cortesoft 10 hours ago
        > I find coding agents can produce very high quality tests if and only if you give them detailed guidance and good starting examples.

        I find this to be true for all AI coding, period. When I have the problem fully solved in my head, and I write the instructions to explicitly and fully describe my solution, the code that is generated works remarkably well. If I am not sure how it should work and give more vague instructions, things don't work so well.

        • stavros 8 hours ago
          Yeah, same. Usually I'll ask the agent for a few alternatives, to make sure I'm not missing something, but the solution I wanted tends to be the best one. I also get into a lot of me saying "hm, why are you doing it that way?" "Oh yeah, that isn't actually going to work, sorry".
        • teaearlgraycold 3 hours ago
          Yes, but the act of writing code is an important part of figuring out what you need. So I’m left wondering how much of a prefect the AI can actually help with. To be clear I do use AI for some code gen. But I try to use it less than I see others use it.
          • cortesoft 2 hours ago
            Eh, I think my decades of experience writing my own code was necessary for me to develop the skills to be able to precisely tell the AI what to build, but I don't think I need to (always) write new code to know how to know what I need.

            Now, if the thing I am building requires a technology I am not familiar with, I will spend some time reading and writing some simple test code to learn how it works, but once I understand it I can then let the AI build from scratch.

            Of course, this does rely on the fact that I have years of coding experience that came prior to AI, and I do wonder how new coders can do it without putting in the work to learn how to build working software without AI before using AI.

      • Vinnl 9 hours ago
        I feel like that leaves me with the hard part of writing tests, and only saves me the bit I can usually power through quickly because it's easy to get into a flow state for it.
      • omgbear 10 hours ago
        Left to his own devices, I found Claude liked to copy the code under test into the test files to 'remove dependencies' :/

        Or would return early from playwright tests when the desired targets couldn't be found instead of failing.

        But I agree that with some guidance and a better CLAUDE.md, can work well!

      • throwup238 10 hours ago
        I've think they're also much better at creating useful end to end UI tests than unit or integration tests, but unfortunately those are hard to create self contained environments for without bringing a lot of baggage and docker containers, which not all agent VMs might support yet. Getting headless QT running was a pain too, but now ChatGPT Codex can see screenshots and show them in chat (Claude Code can't show them in the chat for some reason) and it's been generating much better end to end tests than I've seen for unit/integration.
      • btown 8 hours ago
        Has anyone had success with specific prompts to avoid the agent over-indexing on implementation details? For instance, something like: "Before each test case, add a comment justifying the business case for every assumption made here, without regards to implementation details. If this cannot be made succinct, or if there is ambiguity in the business case, the test case should not be generated."
        • freedomben 7 hours ago
          I've had reasonable success from doing something like this, though it is my current opinion that it's better to write the first few tests yourself to establish a clear pattern and approach. However, if you don't care that much (which is common with side projects):

          Starting point: small-ish codebase, no tests at all:

              > I'd like to add a test suite to this project.  It should follow language best practices.  It should use standard tooling as much as possible.  It should focus on testing real code, not on mocking/stubbing, though mocking/stubbing is ok for things like third party services and parts of the code base that can't reasonably run in a test environment.  What are some design options we could do? Don't write any code yet, present me the best of the options and let me guide you.
              > Ok, I like option number two.  Put the basic framework in place and write a couple of dummy tests.
              > Great, let's go ahead and write some real tests for module X.
          
          and etc. For a project with an existing and mature test suite, it's much easier:

              > I'd like to add a test (or improve a test) for module X.  Use the existing helpers and if you find yourself needing new helpers, ask me about the approach before implementing
          
          I've also found it helpful to put things in AGENTS.md or CLAUDE.md about tests and my preferences, such as:

              - Tests should not rely on sleep to avoid timing issues.  If there is a timing issue, present me with options and let me guide you
              - Tests should not follow an extreme DRY pattern, favor human readability over absolute DRYness
              - Tests should focus on testing real code, not on mocking/stubbing, though mocking/stubbing is ok for things like third party services and parts of the code base that can't reasonably run in a test environment.
              - Tests should not make assumptions about the current running state of the environment, nor should they do anything that isn't cleaned up before completing the test to avoid polluting future tests
          
          I do want to stress that every project and framework is different and has different needs. As you discover the AI doing something you don't like, add it to the prompts or the AGENTS.md/CLAUDE.md. Eventually it will get pretty decent, though never blindly trust it because a butterfly flapping it's wings in Canada sometimes causes it to do unexpected things.
      • anandchowdhary 9 hours ago
        Indeed the case - luckily my codebase had some tests already and a pretty decent CLAUDE.md file so I got results I’m happy with.
      • typpilol 5 hours ago
        I was able to do this with vitest and a ton of lint rules.
    • LASR 9 hours ago
      There is no free lunch. The amount of prompt writing to give the LLM enough context about your codebase etc is comparable to writing the tests yourself.

      Code assistance tools might speed up your workflow by maybe 50% or even 100%, but it's not the geometric scaling that is commonly touted as the benefits of autonomous agentic AI.

      And this is not a model capability issue that goes away with newer generations. But it's a human input problem.

      • anandchowdhary 9 hours ago
        I don't know if this is true.

        For example, you can spend a few hours writing a really good set of initial tests that cover 10% of your codebase, and another few hours with an AGENTS.md that gives the LLM enough context about the rest of the codebase. But after that, there's a free* lunch because the agent can write all the other tests for you using that initial set and the context.

        This also works with "here's how I created the Slack API integration, please create the Teams integration now" because it has enough to learn from, so that's free* too. This kind of pattern recognition means that prompting is O(1) but the model can do O(n) from that (I know, terrible analogy).

        *Also literally becomes free as the cost of tokens approaches zero

        • jaredsohn 8 hours ago
          A neat part of this is it mimics how people get onboarded onto codebases. People usually aren't figuring out how to write tests from scratch; they look at the current best practices for similar functionality in the codebase and start there. And then as they continue to work there they try to influence new best practices.
      • nl 7 hours ago
        It depends on the problem domain.

        I recently had a bunch of Claude credits so got it to write a language implementation for me. It probably took 4 hours of my time, but judging by other implementations online I'd say the average implementation time is hundreds of hours.

        The fact that the model knew the language and there are existing tests I could use is a radical difference.

    • id00 10 hours ago
      I agree. It is very easy to fall in the trap: "I let AI write all the tests" and then find yourself in a situation where you have an unmaintainable mess with the only way to fix broken test within a reasonable time is to blindly accept AI to do that. Which exposes you to the similar level of risk as running any unchecked AI code - you just can't trust that it works correctly
      • piker 10 hours ago
        "My code isn't working. I know, I'll have an AI write my unit tests." Now you have two problems.
    • PunchyHamster 9 hours ago
      Cleanroom design of "this is a function's interface, it does this and that, write tests for that function to pass" generally can get you pretty decent results.

      But "throw vague prompt at AI direction" does about as well as doing same thing with an intern.

    • colechristensen 7 hours ago
      With recent experience I'm thinking the correct solution is a separate agent with prompting to exclusively be a test critic given a growing list of bad testing patterns to avoid, agent 2 gives feedback to agent 1. Separating agents into having unique jobs.

      An agent does a good job fixing it's own bad ideas when it can run tests, but the biggest blocker I've been having is the agent writing bad tests and getting stuck or claiming success by lobotomizing a test. I got pretty far with myself being the test critic and that being mostly the only input the agent got after the initial prompt. I'm just betting it could be done with a second agent.

    • cpursley 10 hours ago
      Which language? I've found Claude very good at Elixir test coverage (surprisingly) but a dumpster fire with any sort JS/TS testing.
  • janaagaard 11 hours ago
    • jdc0589 10 hours ago
      im not saying OP did this, but I've actually had AI spit out some pretty stellar bash scripts, surprisingly
      • cortesoft 3 hours ago
        The emojis give it away
      • anandchowdhary 9 hours ago
        No, you're right. It was a pretty collaborative effort with me and Claude!
        • svieira 9 hours ago
          FYI, you're missing two patterns that allow the `--key=value` admirers and the `-alltheshortopsinasinglestring` spacebar savers among us to be happy (for the otherwise excellent options parsing code).

             shopt -s extglob
             case "$1"
               # Flag support - allow -xyz z-takes-params
               -@(a|b|c)*) _flag=${1:1:1}; _rest=${1:2}; shift; set -- "-$_flag" "-$_rest" "$@";;
               # Param=Value support
               -?(-)*=*) _key=${1%%=*}; _value=${1#*=}; shift; set -- "${_key}" "$_value" "$@";;
             esac
          • insin 1 hour ago
            Gesundheit
          • anandchowdhary 9 hours ago
            For letting me know! Would you like to create a PR? Otherwise I'll add you as a Co-Authored-By!
  • kami23 5 hours ago
    I've dubbed my loop of this as 'sicko mode' at work as I've become a bit obsessed with automating everything little thing in my flow, so I can focus on just features and bugs. It feels like a game to me and I enjoy it a lot.
  • jes5199 4 hours ago
    can it read code review comments? I've been finding that having claude write code but letting codex review PRs is a productive workflow, claude code is capable of reading the feedback left in comments and is pretty good at following the advice.
    • stpedgwdgfhgdd 16 minutes ago
      I’m letting Claude Code review the code as part of a gitlab CI job. It adds inline comments (using curl and the http API, nightmare to get right as glab does not support this)

      CC can also read the inline comments and creates fixes. Now thinking of adding an extra CI job that will address the review comments in a separate MR.

    • jerezzprime 4 hours ago
      Have you tried GitHub Copilot? I've been trying it out directly in my PRs like you suggest. Works pretty well sometimes.
      • jes5199 2 hours ago
        I find that ChatGPT’s Codex reviews - which can also be set up to happen automatically on all PRs - seem smarter than Copilot’s, and make fewer mistakes. But these things change fast, maybe Copilot caught up and I didn’t notice
  • cog-flex 5 hours ago
    Does this exist for Codex?
  • namanyayg 10 hours ago
    Exactly what I needed! I might use it for test coverage on an ancient project I need to improve...
  • leobg 11 hours ago
    Missed opportunity to call it Claude Incontinent (CLI).
  • decide1000 10 hours ago
    How does it handle questions asked by Claude?
    • anandchowdhary 10 hours ago
      It sends a flag that dangerously allows Claude to just do whatever it wants and only give us the final answer. It doesn't do the back-and-forth or ask questions.
      • stpedgwdgfhgdd 14 minutes ago
        Iteratively working is a MUST for more than trivial fixes. This continuous loop could work for trivial refactorings / maintenance tasks.
      • CharlesW 9 hours ago
        The `--dangerously-skip-permissions` flag (a.k.a. "YOLO mode") does do the back-and-forth and asks questions, so this is a bit more than that.
        • brumar 9 hours ago
          Yes. I did not look but most probably the non interactive mode flag is used (-p)
          • anandchowdhary 9 hours ago
            It does `claude -p "This is the prompt" --dangerously-skip-permissions --output-format json`
          • CharlesW 9 hours ago
            Oh! TIL, thank you.
  • mrwill84 2 days ago
    [dead]
  • RonanSoleste 9 hours ago
    [flagged]
  • _dark_matter_ 7 hours ago
    Fyi